Bob Ippolito

Results 254 comments of Bob Ippolito
trafficstars

Removing the label wouldn't really help me confirm when it's fixed it unless I move it out of the extended test suite, and then it would get run for all...

I think something must've changed in the react beta tag that's throwing off rollup's heuristics which causes an issue with the playground build. Taking longer to resolve than I expected.

So far all I know is that there seems to be some sort of issue with the latest build of react beta and the heuristics that @rollup/plugin-commonjs uses to determine...

I've disabled that one new e2e test suite (https://github.com/facebook/lexical/pull/6048/commits/774a2979da8969ec064d11f336ac9f35e68adfba), since it is not a regression and this PR includes other important fixes that should be released sooner than later. Every...

> Yes move it out of extended, get it passing, move it back into extended, get approval. This is also why it shouldn't be running on every PR IMO In...

Giving it another go since I have it all passing locally. Hopefully CI behaves the same way.

Test run is green, removing the workflow hack. https://github.com/facebook/lexical/actions/runs/9131368689/job/25110422301?pr=6048

Merged with main and waiting for review.

Up to date with main, waiting for review.

Since the last time it was reviewed and ready to merge (but was blocked due to the jsx runtime regression & the react 19 beta rollup regression that has a...