Evert Timberg

Results 87 comments of Evert Timberg

No, it's an object that looks like what's shown below. The individual `Feature` objects are the ones that are then drawn on the layer. ``` { type: "FeatureCollection"; features: Feature[];...

That's a good work around. I will look into submitting a PR with the updates 😄

I'd be open to getting through 3.8.1 and 3.9 quickly so that we can start on v4 dev.

Will review this evening my time.

I don't see why this would cause a TS problem, though perhaps the added complexity would make the compiler unhappy in more situations

@Zivangu9 sorry, I didn't have internet yesterday I think I understand where this is coming from. Would it be possible to add a test for the 2 arcs that are...

It almost looks like the angle changes should only apply to arcs that are not 180 degrees exactly.

> I experimented a little with it. Replaced > > https://github.com/chartjs/Chart.js/blob/7432b609c487e1b17c8000fe9f94c58fa65936b8/src/elements/element.arc.js#L340-L342 > > with > > ```js > const fix = 1 + Math.sin(-Math.min(PI, circumference)); > radiusOffset = offset /...

Hmm, not sure if this is breaking or not. The previous behaviour was pretty buggy.