Evert Timberg

Results 87 comments of Evert Timberg

Good point! Thanks for filing this @benmccann

My understanding is that this plugin was created for chart.js v1. One possibility here is to ensure that the canvas is `display: block` otherwise 4px of extra space are added...

@roccomuso @benmccann I'm happy to merge a PR adding something

@simonbrunel @benmccann thoughts on how to handle this? One solution might be to try and if moment errors out, throw something else.

maybe we can just assume ISO8601 .... it makes the deprecation warning go away but it doesn't necessarily solve the problem

I moved this from the main repo, now that the moment adapter code is split out and optional

Specifying the `format` or `parser` option is the best way to go here IMO

There's a sample in the main chartjs repo. https://github.com/chartjs/Chart.js/blob/master/samples/scales/time/line.html

It should work just fine with x/y data https://codepen.io/etimberg/pen/LYbgPmj

There's a simple React example in the Docs now https://www.chartjs.org/chartjs-chart-smith/examples I need to work on updating to the latest Chart.js (v2.9.3) which is likely why you've had to pin `react-chartjs-2`...