Ethan Edwards
Ethan Edwards
Does the code work with time zones? Not sure if you can add it with the % syntax, or if you need to add the ${timezone} variable.
Also, for backwards compatibility, let's keep the existing options at least for the time being. Maybe in the future they can be removed. If you could squash all your commits...
Yes, you need to document the options in INSTALL.md. A baby should be able to follow them ;)
> Should I change to respect the `@dracula-show-timezone` option? I think it might make this option a little bit complicated. IMO, yes.
This sounds like a good idea, if you could implement it and send in a PR that'd be great!
> Any issues with dependencies? Other solutions I've seen required additional installs. Yeah that is a concern, we want to keep it bash only and just using tools like sed,...
LGTM. Will test, thanks for your contribution!
Looks great, is there any way to test this? Maybe in QEMU or something.
This certainly looks good to me.
@madlep any updates?