Erik Thorelli

Results 50 comments of Erik Thorelli

I was thinking about it a bit more, and it should probably not be its own function, but be added to the `run-ios` command. I think in two cases: 1....

> This looks nice! Any chance it could list connected real devices as well as simulators too? Yes! Good call. I didn't test this out, but should be doable. I'll...

> Thanks for the contribution @esthor ! 💪 > > > I wanted to put this up as a WIP first because I don't know which path to take next......

Awesome, @thymikee. Thanks. Do you know of any interactive cli functionality already in the repo? I didn't find anything in a quick glance. I want to make sure I don't...

Thanks! I also found an unrelated bug while working on this, and put up a PR: https://github.com/react-native-community/cli/pull/1675

Two things that we might want to follow-up on: 1. update tests (the `findMatchingSimulator.test.ts` still just passes `device.availability` mocks, so it should probably have some mocks with `device.isAvailable`) 2. make...

> Would you be so kind and refactor this so more code is being shared, to avoid such discrepancies in the future? Yes, 💯 . I wanted to propose this,...

> > > Would you be so kind and refactor this so more code is being shared, to avoid such discrepancies in the future? > > > > > >...

Works to hack this hardcoded location variable (and avoid geolocation function) in Übersicht 0.9. But why it is failing is still unanswered? Anyone have any ideas?

Hi @nidelson -- Another PR was recently merged: https://github.com/ohmyzsh/ohmyzsh/pull/11191 Can this PR be closed?