ohmyzsh icon indicating copy to clipboard operation
ohmyzsh copied to clipboard

docs(react-native): add docs for iPhone 12

Open nidelson opened this issue 1 year ago • 7 comments

Standards checklist:

  • [x] The PR title is descriptive.
  • [x] The PR doesn't replicate another PR which is already open.
  • [x] I have read the contribution guide and followed all the instructions.
  • [x] The code follows the code style guide detailed in the wiki.
  • [x] The code is mine or it's from somewhere with an MIT-compatible license.
  • [x] The code is efficient, to the best of my ability, and does not waste computer resources.
  • [x] The code is stable and I have tested it myself, to the best of my abilities.

Changes:

  • [x] adds documentation for using the simulator with iPhone 12 / Pro / Max
  • [x] fixes Markdown format

Other comments:

The aliases were already implemented.

nidelson avatar Jun 16 '22 19:06 nidelson

My first pull request on project. o/

nidelson avatar Jun 20 '22 15:06 nidelson

Crazy to send the next one... after the approval of this.

nidelson avatar Jun 24 '22 02:06 nidelson

Waiting approvers...

nidelson avatar Jul 15 '22 00:07 nidelson

Could you fix the diff in the README.md? I think you may have inadvertently changed the formatting on the entire file instead of the couple line change.

I used MarkdownLint and it helped me to format it automatically.

Just added my 2 lines and saved. He did everything else! 🤷

nidelson avatar Aug 11 '22 18:08 nidelson

Could you fix the diff in the README.md? I think you may have inadvertently changed the formatting on the entire file instead of the couple line change.

I used MarkdownLint and it helped me to format it automatically.

Just added my 2 lines and saved. He did everything else! 🤷

Could you add the 2 lines (without re-formatting) and push that 2-line diff instead?

Basically, the issue is it's a lot of unnecessary churn and noise. For example, consider if the next person that adds a line or two uses a slightly different lint config, it would again show the entire file changing when really it was just a line or two.

esthor avatar Aug 11 '22 18:08 esthor

Okay!

nidelson avatar Aug 11 '22 18:08 nidelson

Hey @nidelson would you have time this week to add that updated commit (that removes the re-formatting, so it's just the 2-line diff in the README.md)?

Please lmk if you'd like some help. I'd be happy to push it up to your branch. 🙌

EDIT: For context, I've got a branch that I want to PR, but it will have conflicts with yours as-is. So, I wanna wait until yours is merged.

esthor avatar Aug 23 '22 17:08 esthor

Hi @nidelson -- Another PR was recently merged: https://github.com/ohmyzsh/ohmyzsh/pull/11191

Can this PR be closed?

esthor avatar Oct 03 '22 15:10 esthor

Thanks for the contribution Nidelson! Ping me directly if in the future you make another PR and I will make sure to prioritize it.

mcornella avatar Oct 03 '22 15:10 mcornella