cli icon indicating copy to clipboard operation
cli copied to clipboard

List Available Apple Devices

Open esthor opened this issue 2 years ago • 4 comments

Describe the Feature

Instead of passing the --simulator "{some apple device simulator string}" I would like an interactive option to first list the available simulators and select the one I want.

Possible Implementations

  1. add a list command of --list flag to run-ios command
  2. Reuse available device listing & parsing logic in findMatchingSimulator.ts to print the devices to the console
  3. User can use arrows to select the device
  4. The selected devices is passed to a react-native run-ios --simulator "{selected apple device simulator name}" command

Related Issues

Not in this repo, but a very popular tool called ohmyzsh has a plugin for react-native, and to be up-to-date it is manually updated with device simulator flags. I think this main benefit of this aliasing plugin would be surpassed by an interactive list available devices function in the CLI itself.

For those not using the above ohmyzsh plugin, having this part of the CLI itself would be easier and clearer, and users wouldn't need to open up xCode to see available simulators or run xcrun simctl list devices either.

I'm happy to work on it, but wanted to know first if it would be well-received or not. 🙏

esthor avatar Aug 11 '22 17:08 esthor

Sounds like something useful, happy to review PR :)

thymikee avatar Aug 11 '22 17:08 thymikee

Awesome, @thymikee. Thanks.

Do you know of any interactive cli functionality already in the repo? I didn't find anything in a quick glance. I want to make sure I don't introduce some new pattern if there already is an established one.

esthor avatar Aug 11 '22 17:08 esthor

Doctor command has some, you can check that

thymikee avatar Aug 12 '22 07:08 thymikee

Thanks! I also found an unrelated bug while working on this, and put up a PR: https://github.com/react-native-community/cli/pull/1675

esthor avatar Aug 12 '22 16:08 esthor

There hasn't been any activity on this issue in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.

github-actions[bot] avatar Nov 24 '22 03:11 github-actions[bot]

Closing since it's done by https://github.com/react-native-community/cli/pull/1676.

szymonrybczak avatar Jan 25 '23 22:01 szymonrybczak