Eric Sheppard

Results 99 comments of Eric Sheppard

Thanks for the report @atouchet - will get this cleaned up along with some other changes in https://github.com/chronotope/chrono/pull/793

Thanks @cjrh - we will likely use https://github.com/chronotope/chrono/pull/814 to fix this, which includes all changes of your PR, but also removes the shell files used in CI in favour of...

Thanks for this PR @mqudsi - this looks like a good complement to some work in #814, as this PR has picked up some issues with the doc tests that...

Interesting question @WhyNotHugo - it may take a bit of back and forth to settle on a good design for this, however that may be useful to inform a potential...

I've done some exploration around possible changes to `TimeZone` to make it object safe, and also looking at using `FixedOffset` everywhere to avoid the `Offset` trait in: https://github.com/chronotope/chrono/pull/830

My thinking around the naming is as follows * Some types are prefixed with `Naive` to both signify that they are missing information, but also gently encourage use of non-`Naive`...

Sorry to jump in kind of late here, but could we use something like: [nonmax](https://docs.rs/nonmax/latest/nonmax/index.html) to hold the nanos?

Is it worth us benchmarking both methods so that we have some empirical evidence to inform the direction we choose?

Interestingly if this works nicely with `nonmax`, potentially it could be used to replace the `i32` of the `DateImpl` as well, allowing `Option` to be the same size as `NaiveDate`

Thanks for raising the issue @udoprog. I think it should definitely be considered whether we promote the `Option` returning methods as the default ones, rather than the panicking ones. We...