chrono icon indicating copy to clipboard operation
chrono copied to clipboard

Published 20 hours ago • verified publisher icon chronotope

Leftover Travis CI references

Open atouchet opened this issue 3 years ago • 4 comments

Travis CI support was removed in #436 but there are still some leftover references remaining in the project.

https://github.com/chronotope/chrono/blob/3467172c31188006147585f6ed3727629d642fed/Makefile#L25

https://github.com/chronotope/chrono/blob/17d8c2af865f14b83154a0112f372fcf1718b481/Cargo.toml#L12

atouchet avatar Aug 25 '22 20:08 atouchet

Thanks for the report @atouchet - will get this cleaned up along with some other changes in https://github.com/chronotope/chrono/pull/793

esheppa avatar Aug 26 '22 13:08 esheppa

Since #793 got closed, I've made a new PR #816 containing only these fixes.

cjrh avatar Sep 10 '22 02:09 cjrh

Thanks @cjrh - we will likely use https://github.com/chronotope/chrono/pull/814 to fix this, which includes all changes of your PR, but also removes the shell files used in CI in favour of putting everything in the yaml files.

esheppa avatar Sep 10 '22 04:09 esheppa

Ah ok, I didn't know. Should I close my PR then?

cjrh avatar Sep 10 '22 04:09 cjrh

I believe these leftover references are all gone now.

pitdicker avatar Jun 06 '23 18:06 pitdicker

https://github.com/chronotope/chrono/blob/088b69372e93e64f144183fb3324cdb079736f8b/Makefile#L22

This file still references travis.sh.

atouchet avatar Jun 06 '23 20:06 atouchet

@atouchet Thank you for looking into it again! Removed the Makefile in https://github.com/chronotope/chrono/pull/1133.

pitdicker avatar Jun 07 '23 08:06 pitdicker