Erik Seliger

(POC) Integrate Batch Changes into GitHub App integration

5

GitHub Apps are being introduced in other parts of the system, currently mostly for Cloud but I heard that it might expand to on-premise as well. In FY24 for Cloud,...

gitserver: Simplify invocation of p4-fusion

1

This wrapper existed to track performance issues, but we have since added better logging options for that through storing the last output and the ability to log to a file....

gitserver: Improve signal handling and maxRSS reporting

1

This PR makes a change to how we spawn git processes, it puts them in separate process groups. This will allow us to track maxRSS reliably, and also lets us...

httpcli: Remove useless err check

1

We return right above if err == nil, so this check is redundant. Test plan: CI passes, no change in behavior.

httpcli: Unexport internal client factory

1

Not used anymore outside of this package, and is in line with what we do for the external doer factory. Test plan: CI passes, go compiler doesn't complain.

embeddings: Use default InternalDoer

1

We don't really use embeddings right now and this lets me encapsulate the factory better in the next PR, as this is the only external caller of NewInternalClientFactory. Test plan:...

httpcli: Move init function from conf package into httpcli

1

There was a weird dependency between internal/conf and internal/httpcli because of a cyclic import. This is resolved by using conftypes instead, so we can properly split those concerns. Test plan:...

rockskip: Switch from long-running process to pagination

1

We want to migrate this call to gRPC. However, it isn't good practice to have to keep this process running for potentially hours, as any server restart will have to...

rockskip: Replace second long-running process with API

1

We want to migrate this call to gRPC as well. However, it isn't good practice to have to keep this process running for potentially hours, as any server restart will...