Erik Seliger
Erik Seliger
I agree with you guys Requesting to check the size based on brotli compression and getting an OK return code seems wrong
how about running it once and checking for failure and then running `npm i brotli-size` and running again and check for success?
hmm maybe some script like this will work ``` bundlezise if [ $? -eq 0 ] then echo "Should have failed" exit 1 else exit 0 fi ```
If I get your point correctly, you are worried about using the wrong version of gulp with this plugin? If not, please correct me. If that is what you are...
Link to the (very hidden) renovate dashboard I discovered a while ago, good for checking renovate logs and to see if a renovate job is currently running: # https://app.renovatebot.com/dashboard#github/sourcegraph/sourcegraph
@googlebot I signed it!
> One alternative idea here is that we do actually know what external service(s) are being queried [when the version map is being built](https://sourcegraph.sourcegraph.com/github.com/sourcegraph/sourcegraph@3bd84df7c9041f577372d9bab3127e50c7ad999c/-/blob/internal/extsvc/versions/sync.go?L69:6), so we could extend [Version](https://sourcegraph.sourcegraph.com/github.com/sourcegraph/sourcegraph@3bd84df7c9041f577372d9bab3127e50c7ad999c/-/blob/internal/extsvc/versions/store.go?L15-18) to...
Should we instead say the config has to be _parseable_?
Might be that this PR would fix it, too (didn't dive too deep): https://github.com/sourcegraph/sourcegraph/pull/42039
is this ready for review? I saw you removed the review request