sourcegraph icon indicating copy to clipboard operation
sourcegraph copied to clipboard

gitserver: Simplify invocation of p4-fusion

Open eseliger opened this issue 1 year ago • 1 comments

This wrapper existed to track performance issues, but we have since added better logging options for that through storing the last output and the ability to log to a file. We can also expand the git command tracking to the perforce command factory to track all of this even more reliably.

This adds another layer of indirection that could cause trouble, so simplifying here and calling p4-fusion directly, like we do in the p4-fusion CI pipeline.

Also talked to Peter about this who initially added it, the sole reason was process metrics tracking, so this should be safe.

Test plan:

The p4 integration test still passes.

eseliger avatar Apr 21 '24 18:04 eseliger

  • #62070 Graphite 👈
  • #62095 Graphite
  • main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @eseliger and the rest of your teammates on Graphite Graphite

eseliger avatar Apr 30 '24 12:04 eseliger