Maic Siemering comments

Results 136 comments of


                                            Maic Siemering

service_id and plan_id checks

> Hello Maic. I hope you are going well. I tried to submit a few merge requests a few weeks ago. Have you had time to review them? If something...

Integration test with example broker

I still consider this as something to do at a later point in time.

Bump pygments from 2.14.0 to 2.15.0

@dependabot recreate

Bump pre-commit from 3.2.2 to 3.3.3

@dependabot recreate

Provide the service broker with a "health check" endpoint for monitoring purpose

Update: My idea is to document, how to implement this using project specific code. The implementation for a broker that may provide multiple services in one would require a status...

Bump certifi from 2022.12.7 to 2023.7.22

@dependabot recreate

Add parameters validation against schemas

I took some more time for looking into this direction. From the spec I do not see any hint about service brokers should implement the validation: > Platforms MUST support...

Add parameters validation against schemas

I also thing about doing some heavier lifting. -> Switch to FastAPI (use Python type hints and Pydantic schema validation)

Add parameters validation against schemas

I see the point of supporting easier schema validation. I am still not sure if it would be the right way to have it as a build in feature instead...

set AWS_SESSION_TOKEN

Would be great if the plugin could just set session token env var if it exists in the item. That would support the case with ease.