openbrokerapi icon indicating copy to clipboard operation
openbrokerapi copied to clipboard

Published 20 hours ago • verified publisher icon eruvanos

service_id and plan_id checks

Open redorff opened this issue 3 years ago • 4 comments

redorff avatar May 04 '21 08:05 redorff

Coverage Status

Coverage increased (+2.06%) to 95.745% when pulling 5b468e0f9a26c248ddfb1cc89ece280927bb2d55 on redorff:service_id_and_plan_id_checks into 32b5e13998fb0bccc80e04d73303fa91722deba8 on eruvanos:main.

coveralls avatar May 04 '21 08:05 coveralls

Hello Maic. I hope you are going well. I tried to submit a few merge requests a few weeks ago. Have you had time to review them? If something is wrong, please tell me and I'll do my best to fix it. Best regards.

redorff avatar Aug 06 '21 12:08 redorff

Hello Maic. I hope you are going well. I tried to submit a few merge requests a few weeks ago. Have you had time to review them? If something is wrong, please tell me and I'll do my best to fix it. Best regards.

Hi, thanks for the contribution, I was a little bit busy regarding another open source project. I merged your two pull requests and will have a look into this one as well. Greetings

eruvanos avatar Oct 14 '21 08:10 eruvanos

Great to see you back on this project! :) Don't worry, I will resolve the conflicts... I also have many more evolutions to submit... By the way, what do you think of "black", the code formatter? I started using it on my fork... I think it's pretty good...

redorff avatar Oct 14 '21 16:10 redorff