Maic Siemering comments

Results 136 comments of


                                            Maic Siemering

Support "outline" for text

I will have a look, if I might be able to do it myself. Thank you for the hint

Minimap example broken: Minimap has some offset

Will check

Minimap example broken: Minimap has some offset

Everything works like expected

Reinvent the Rectangle, or The First Step Towards Rectangle Unification.

Just agreed (with @DigiDuncan) that RectInt should be removed after we merged this huge PR.

Reinvent the Rectangle, or The First Step Towards Rectangle Unification.

> Could we get a mutable rect as well? Right now we stick to the immutable version only. From my point of view, the convenience benefits are not big enough...

Reinvent the Rectangle, or The First Step Towards Rectangle Unification.

So summary: I am fine with the PR. @einarf @pvcraven please give feedback what you think about the naming of the Rect constructor functions (XYWH, LBWH, ...) being uppercase. I...

Reinvent the Rectangle, or The First Step Towards Rectangle Unification.

@DigiDuncan Can you check, if you can make the PR mergable?

GUI: UILabel lacks call to "fit_contents"

fit_content does overwrite width and height. So if you give it a explicit size, that would just be overwritten. Feedback demanded: Would this fit more your expectation?

GUI: UILabel lacks call to "fit_contents"

Hi, I looked further into it. I changed the default of UILabel.size_hint to (0,0). The size_hint_min is already updated after a text is set. The behaviour allows for all use...

Improve beginner friendliness of output from ./make.py format

Looks good to me. Can we highlight the lint command somehow? for beginners it is the most important (and for me 😅 )