Erik Rothoff Andersson
Erik Rothoff Andersson
@ardingchen I recently merged a similar fix (albeit simpler) that might fix this issue. Could you give it a try? Thanks!
@hellofy like a tagged version release on this repo?
I agree with @googollee here. I prefer to have the option to close a connection and choose to prepare the server, than to hide it inside the library. It's a...
@Mistic92 yes, this project needs help
We just use a version of the client library that this library supports. Would be great to have this library support later versions, but the lack of maintainers should be...
We use socket.io for our web app: https://feeder.co if you create an account you can see when it connects to our go server.
Seems to be related to this: https://github.com/googollee/go-socket.io/blob/master/broadcast.go#L93 Not sure why it's locking even during the .Emit. I assume it only needs to block while actually reading the current list of...
It seems to be a fairly easy fix. Not letting the `.Emit` call in `broadcast.Send` block by using go-routines. This is how the node-implementation works. https://github.com/googollee/go-socket.io/blob/0c0217c03e1d56780f85e83696203837b62f58ef/broadcast.go#L101 ```go // change connection.Emit(event,...
We're running this in production for a long time
To not have all the work you did @googollee on 1.4 completely out the window, would you mind just describing the performance enhancements you mentioned for the 1.4 branch, compared...