Erik Rothoff Andersson comments

Results 86 comments of


                                            Erik Rothoff Andersson

Add documentation for how to use rooms

@armin-ahmadi are you the person to make it happen? 💪 💪 💪

EOF error when sending non-UTF-8 strings

I take it this only happens when not using something like JSON that encodes UTF-8 characters?

[BUG] Meet EOF error with join to server on WebSocket

Is this a socket 2 vs 1 issue?

git.apache.org/thrift.git is no longer available

Please make a PR

OnEvent in same nps with OnConnection dont work

Don't you need to wait for the connection to be made before emiting?

Unexpected multiple emits (multiple rooms joined)

Should be a fairly easy fix, to use a map instead of just plainly emitting. Note I've released the lock earlier, which should be better for performance? What do you...

Unexpected multiple emits (multiple rooms joined)

I think it's an interesting tradeoff, making a map per broadcast might be slow vs the extra memory of keeping every connection in a default room. I'd actually vote for...

Unexpected multiple emits (multiple rooms joined)

Then it's a question of how much memory should we allocate for this scenario. Our use case for sockets does not require it, so it will add extra overhead that...

Unexpected multiple emits (multiple rooms joined)

I was looking at that just yesterday as well! I think it's a good solution to just use the map to see who has been "emit"ed in the loop. I...

NamedStyles typing error with Image component

Is a PR too late to ask for?