Erik Joelsson

Results 22 comments of Erik Joelsson

1452: Can never notify on first commit

Solving this is more complex. I added more information to the bug.

1452: Can never notify on first commit

> I want to confirm whether I understand you correctly. > > Case1: Completely new repo or repo with few commits In this situation, we should let the notify bot...

1452: Can never notify on first commit

This comment is just a test.

1618: CSR bot failed to update PR when CSR was approved

> But I don't think it is the root cause of SKARA-1618. The `IssueWorkItem#concurrentWith` currently only checks the issue project's name and doesn't check the issue id and repos' names...

1618: CSR bot failed to update PR when CSR was approved

/integrate

1584: Require re-review of a PR if the target branch changes

I believe the tests are failing due to intermittent failures in the poller. That should be fixed by https://github.com/openjdk/skara/pull/1380.

1584: Require re-review of a PR if the target branch changes

/integrate

8295231: Move all linking of native libraries to make

> The change looks harmless. Howevere I don't understand how searching for the standard Windows libs can then become frustrating. I believe this is part of the effort for https://bugs.openjdk.org/browse/JDK-8288293.

2191 Handle multiple available skara.gitconfig files

/sponsor

2170: Warn on trailing period in PR titles

> This PR is ready for review. Could someone please review it? ping... Sorry, I saw your comment about it not being ready so assumed you would say something when...