skara icon indicating copy to clipboard operation
skara copied to clipboard

2191 Handle multiple available skara.gitconfig files

Open LudwikJaniuk opened this issue 11 months ago • 5 comments

This adds "tail -1" to the bootstrap mechanism, to handle the case if we find more than one skara.gitconfig file. The alternative is to execute a malformed shell invocation.


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace

Issue

  • SKARA-2191: Handle multiple available skara.gitconfig files (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/skara.git pull/1618/head:pull/1618
$ git checkout pull/1618

Update a local copy of the PR:
$ git checkout pull/1618
$ git pull https://git.openjdk.org/skara.git pull/1618/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1618

View PR using the GUI difftool:
$ git pr show -t 1618

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/skara/pull/1618.diff

Webrev

Link to Webrev Comment

LudwikJaniuk avatar Mar 05 '24 13:03 LudwikJaniuk

:wave: Welcome back lujaniuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Mar 05 '24 13:03 bridgekeeper[bot]

Webrevs

mlbridge[bot] avatar Mar 05 '24 13:03 mlbridge[bot]

@LudwikJaniuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

:mag: One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

:earth_americas: Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

2191: Handle multiple available skara.gitconfig files

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk[bot] avatar Mar 05 '24 13:03 openjdk[bot]

/integrate

LudwikJaniuk avatar Mar 05 '24 13:03 LudwikJaniuk

@LudwikJaniuk Your change (at version 01bc4e5cecb163a75c9b7b3b0e7681d7b59d821c) is now ready to be sponsored by a Committer.

openjdk[bot] avatar Mar 05 '24 13:03 openjdk[bot]

/sponsor

erikj79 avatar Mar 11 '24 13:03 erikj79

Going to push as commit 5b84d05ee246b63dced10f5e86456f95115cc152. Since your change was applied there has been 1 commit pushed to the master branch:

  • af682b4508b48a098ff5cbd53d0db37a94cdf32b: 2190: Setting maximum size limit for PR diff in generating Webrev

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Mar 11 '24 13:03 openjdk[bot]

@erikj79 @LudwikJaniuk Pushed as commit 5b84d05ee246b63dced10f5e86456f95115cc152.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Mar 11 '24 13:03 openjdk[bot]