Erik Joelsson
Erik Joelsson
> I don't really know whether it is a good idea to has both CSRIssueBot and CSRPullRequestBot. It seems that one CSRBot contains two work items, `IssueWorkItem` and `PullRequestWorkItem`, works...
> > I don't really know whether it is a good idea to has both CSRIssueBot and CSRPullRequestBot. It seems that one CSRBot contains two work items, `IssueWorkItem` and `PullRequestWorkItem`,...
Thanks! /integrate
This is a huge patch and I have started reviewing it. Can't promise when I will be able to post it.
> After reading your comment, I think it is better to implement the approval feature in the pr module instead of adding the new approval module. Maybe we can begin...
Looking at logs, this is now working as intended.
This change is currently blocking deployment of new changes to Skara bots, unless we back out [SKARA-1590](https://bugs.openjdk.org/browse/SKARA-1590). This is because the PullRequestPoller isn't behaving well enough to actually be used...
> First of all, I think your changes are fine, the reasoning and the code checks out. I have a bunch of suggestions, but those you can choose whether you...