Eric Van Norman
Results
210
comments of
Eric Van Norman
LGTM. Thanks for all the work on this PR.
Maybe we need to move some of the README info either out to the main samples directory or create/update the various READMEs as needed. Similar to Bookinfo we would want...
I do think we want the ability to update src and images, but agree that the process there is not the best.
The readme was recently updated, https://github.com/istio/istio/pull/41096, to mention that this is a known issue.
Can we remove the `common-files` change now that we know things will pass with the forth coming change. Or is the common-files change needed to get things to pass now?
/test integ-basic-arm64
@istio/wg-environments-maintainers review?
Should this require a release note?