Eric Svendsen

Results 10 comments of Eric Svendsen

@aldeka interesting. I was seeing the same error you're seeing. Then I noticed that [this comment](https://github.com/aakashns/create-component-lib/issues/1#issuecomment-454985437) had the same error as well. So I adjusted my `devDependencies` as suggested, and...

The ability to programmatically control border tab visibility would be SO helpful. Until I found this issue, I thought for sure the below code would work and was surprised when...

Hmm, ok nevermind. Calling `selectTab` will indeed cause the border tabset to expand. Sorry, I think I misunderstood the original intent of this issue.

Nicely done. I wish this would get merged - for now I just cloned your branch.

Any possibility of getting this resolved? I too am using the latest version of Knex (at this time, 0.95.14) with Bookshelf 1.2.0 just fine. Using the `--legacy-peer-deps` will skip peerDependencies...

@kibertoad Yeah absolutely! Sorry, I made the comment and had to move on at the time. Thanks for the reminder.

@kibertoad finally got back to this, and the commits in the [already existing PR](https://github.com/bookshelf/bookshelf/pull/2120) look good to me, aside from the additional comment I made in that discussion thread. Obviously...

@throrin19 Nope, sorry. I'm just an outsider looking in, so I have no idea if there are plans to address open PRs or not.

I can't do much to help it along, but I did get back around to looking at this lately. From what I can tell, the only other change that would...