machinelearning icon indicating copy to clipboard operation
machinelearning copied to clipboard

Update .NET libraries and runtime dependencies

Open ericstj opened this issue 3 years ago • 3 comments

Update to the latest libraries for all dependencies of ML.NET that come from dotnet/runtime (and prior) repositories.

I noticed that the dependency on PlatformAbstractions.RuntimeEnvironment.GetRuntimeIdentifier(); was broken because DependencyModel stopped referencing PlatformAbstractions. I was able to fix this by refactoring that code to use https://docs.microsoft.com/en-us/dotnet/api/system.runtime.loader.assemblydependencyresolver?view=net-6.0 which exists since .NETCore 3.0 and calls in to the host to probe for deps-file-defined dependencies. I've tested that this works with both local runtime dependencies and nuget cache probing.

ericstj avatar Apr 22 '22 00:04 ericstj

Codecov Report

Merging #6168 (67f8fef) into main (c0d449f) will decrease coverage by 3.78%. The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main    #6168      +/-   ##
==========================================
- Coverage   68.42%   64.63%   -3.79%     
==========================================
  Files        1144     1144              
  Lines      244991   244932      -59     
  Branches    25411    25401      -10     
==========================================
- Hits       167627   158315    -9312     
- Misses      70697    80214    +9517     
+ Partials     6667     6403     -264     
Flag Coverage Δ
Debug 64.63% <90.90%> (-3.79%) :arrow_down:
production 60.23% <ø> (-2.64%) :arrow_down:
test 80.97% <90.90%> (-8.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...oft.ML.TestFrameworkCommon/Utility/PathResolver.cs 95.23% <90.90%> (+37.73%) :arrow_up:
src/Microsoft.ML.Vision/VisionCatalog.cs 0.00% <0.00%> (-100.00%) :arrow_down:
src/Microsoft.ML.OnnxTransformer/OnnxOptions.cs 0.00% <0.00%> (-100.00%) :arrow_down:
src/Microsoft.ML.TensorFlow/TensorflowCatalog.cs 0.00% <0.00%> (-100.00%) :arrow_down:
...ft.ML.Tests/Transformers/TimeSeriesImputerTests.cs 0.00% <0.00%> (-100.00%) :arrow_down:
....ML.Tests/Transformers/DateTimeTransformerTests.cs 0.00% <0.00%> (-100.00%) :arrow_down:
...L.DnnImageFeaturizer.ResNet18/ResNet18Extension.cs 0.00% <0.00%> (-100.00%) :arrow_down:
...est/Microsoft.ML.Tests/TensorFlowEstimatorTests.cs 0.00% <0.00%> (-98.51%) :arrow_down:
...t.ML.OnnxTransformerTest/DnnImageFeaturizerTest.cs 0.00% <0.00%> (-96.63%) :arrow_down:
src/Microsoft.ML.TensorFlow/TensorFlowModel.cs 0.00% <0.00%> (-96.00%) :arrow_down:
... and 99 more

codecov[bot] avatar Apr 22 '22 01:04 codecov[bot]

/// Third: The library as resolved via the default DependencyContext, in the default nuget package cache folder.

This comment should probably be updated.


Refers to: test/Microsoft.ML.TestFrameworkCommon/Utility/PathResolver.cs:35 in 03a1b02. [](commit_id = 03a1b029222eaa798f4bad0f9992746ba1bcd23e, deletion_comment = False)

eerhardt avatar Apr 25 '22 15:04 eerhardt

I haven't yet fixed the tests here, needed to get some fresh results.

ericstj avatar Aug 05 '22 17:08 ericstj

Closing this stale PR for now

ericstj avatar Mar 15 '24 01:03 ericstj