Eric StJohn

Seems like `CA2213` should have caught these, but it's disabled. It would be good to re-enable it and ensure it catches these problems and ensure we got them all. Separately...

Please hold off on merging this - I'd like to get other changes in which have conflicting changes. #6939

Note - ONNX sample doesn't require separate tokenizer. @LittleLittleCloud might need this for a solution that works with torchsharp.

@michaelgsharp made a good observation offline - we're seeing memory usage go up quite a bit as the tests progress. ``` Finished test: Microsoft.ML.TorchSharp.Tests.TextClassificationTests.TestSentenceSimilarity with memory usage 2,077,020,160.00 and max...

Wow - the memory usage of this test is *very* high. Here's what I see from a local passing run on Windows. ``` Discovering: Microsoft.ML.TorchSharp.Tests (method display = ClassAndMethod, method...

Stack of the crash is here: ``` # Child-SP RetAddr Call Site 00 00000045`0d5bf920 00007ffc`3e0ceffd lib_lightgbm!LightGBM::CreatePredictionEarlyStopInstance+0x2c9dd 01 00000045`0d5bf950 00007ffc`3e0cf1d1 lib_lightgbm!LightGBM::ObjectiveFunction::CreateObjectiveFunction+0x9ea7d 02 00000045`0d5bf980 00007ffc`3e0dafbe lib_lightgbm!LightGBM::ObjectiveFunction::CreateObjectiveFunction+0x9ec51 03 00000045`0d5bfa10 00007ffc`64909f2a lib_lightgbm!LGBM_DatasetPushRowsByCSR+0x36e 04 00000045`0d5bfa90...

We have a few customer reports of similar errors too: https://github.com/dotnet/machinelearning/issues/6817 https://github.com/dotnet/machinelearning/issues/3615 https://github.com/dotnet/machinelearning/issues/6426 https://github.com/dotnet/machinelearning/issues/3872 https://github.com/dotnet/machinelearning/issues/3340

CC @pgovind @eerhardt

@joeloff mentioned the lift from v3 to v4 might have some challenges that make it more expensive. I read through the WIX issues that fixed the MAX_PATH problem - essentially...

Discussed this with @JeremyKuhne and he pointed me to https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry - [x] needs a registry key, which should be set on our build machines and dev machines - [ ]...