Eric StJohn

Results 305 comments of Eric StJohn

> Oh and this reminds me, is there any reason why on x64 macos that we can install from the arm64 bundles? That seems unusual, mind opening a separate bug...

Transferred this to dotnet/installer for visibility.

It sounds like option 1 is preferable. Is the only side-effect a breaking change that makes PrimitiveDataFrameColumn abstract? Do we know if anyone would actually be trying to create instances...

I may go ahead and do the refactoring of the build pipeline to stop passing in the test TFM. That's a bit of a hack and it's what's causing one...

Ok, I rewrote how we compose the test payloads. This makes this more distributed and will give tests the ability to control this in the project and targets - and...

Getting closer here. Most remaining failures are on Arm and need unique baseline updates. I'm thinking to add a test script used by the tests that copies any outputs on...

> But at some point new columns were added to the DataFrame that didn’t follow this rule. For example StringDataFrameColumn, DateTimeDataFrameColumn and DecimalDataFrameColumn. These columns have different from Arrow format...

Seems the same is true for tokenizers. https://learn.microsoft.com/en-us/dotnet/api/microsoft.ml.tokenizers?view=ml-dotnet-preview It would be good to get this fixed for 3.0.0, 3.0.1, and our latest 4.0.0 preview. @gewarren do you know what we...

I see, digging through some old mail I see mention of https://apidrop.visualstudio.com/binaries/_git/mrefconfig?path=%2Fbundlepackages%2Fml-dotnet but I don't see us ever changing that. I'll see if I can navigate that request form :)

Looks like xunit.runner will return either 0 or 1 for normal cases: https://github.com/xunit/xunit/blob/c10b7a2884edcb69a4afe0af6bf241f5565e99e9/src/xunit.console/ConsoleRunner.cs#L101C24-L101C33 I think we just need to swallow the `1` value.