Song Eric Yu Li
Song Eric Yu Li
Apologies for the repeated force pushes, my code is failing a few tests. Running the tests on my own machine is really annoying because a lot of them are flaky...
Apologies for the square brackets. I've corrected them to backticks where possible and will continue to do so in the future. As per discussions on Discord, I've removed basically all...
Ah, something I've just thought of. Should I rename `EditNotifications` to `EditReviewReminders`? I've noticed that I sometimes substitute the word "notifications" for "review reminders" in my code which is probably...
As per @lukstbit's recommendation, I've rebased and squashed all my commits together. I've done a major refactoring to switch `EditNotifications` into `ScheduleReminders` and am now using a fragment within `SingleFragmentActivity`...
Please do not review this PR. I'm actively refactoring it as I've realized I can streamline the UX. Sorry for asking for reviews and then going back and changing things...
Refactored. UI images in the PR description have been updated. Looking forward to reviews!
Thanks Ashish and Sanjay! Updated.
- Replaced `launchCatchingIO` with `viewModelScope.launch`
Cool! Thanks for the review. Since there are two approvals, I can mark this as Pending Merge, right?
I've incorporated the above suggestions into my code and will open up a PR for the updates once https://github.com/ankidroid/Anki-Android/pull/18364 is merged.