Song Eric Yu Li

Results 43 comments of Song Eric Yu Li

Hi, here's a first draft of what I'd like the review reminder storage local database storage system to be like. Looking forward to constructive criticism. For now, I’ve put these...

Had to do a second force push because I forgot to move the files to a new package as outlined at #18318.

Repeated force push because I forgot to rebase, my bad.

Hi, I've refactored to use SharedPreferences instead of Preferences Datastore. In retrospect, thanks for telling me to use it, it really is a lot more simple and I should have...

I realized the SharedPreferences keys are too short. Since there's tons of other things being stored in SharedPreferences, it's probably a good idea to append `review_reminders_` to the beginning of...

I realized while I was building out the ScheduleReminders RecyclerView more that: 1. There are typos in this commit, whoops. 2. I need to store a review reminder's corresponding deck...

Rebased and fixed a List that should have been a MutableList.

- Added a ReviewReminderId typealias. - Tweaked the contracts of the database's "edit" methods to now require a lambda which returns a List rather than strictly a MutableList. - Added...

Please do not review this PR. I'm actively refactoring it as I've realized I can streamline the UX. Sorry for asking for reviews and then going back and changing things...

Refactored. Removed ReviewReminderTypes and replaced it with snoozing. Looking forward to reviews!