Erick Zhao

Results 246 comments of Erick Zhao

I think there are some legitimate test failures that we'll have to investigate in `slow-tests`. It may be that `pnpm` is hanging somewhere along the line? It seems like all...

Potentially related to this symlink issue https://github.com/electron/asar/pull/308

@twann503 I don't think this is the same error. The error for this one is `links out of the package` and yours says `Cannot copy to a subdirectory of itself`.

Hey @patcon, Great to see interest in the plugin! I feel like it'd be a cool use case to add in. Feel free to take initiative on it! 😄

🤔 Sounds like a good idea! Will look into it as soon as I have the time.

@arya-vats I don't think there's an active task to work on with this issue.

> fix the old node modules Could you elaborate on this? I'm not sure I understand.

Hey @Nashorn There's already a note for this in the README but I think it could be more clear since renderers are sandboxed by default in Electron 20: > Note:...

I think a historic log might be a helpful resource. For current versions, it's displayed on https://github.com/electron/electron?tab=readme-ov-file#platform-support

There's already a PR up for this. https://github.com/electron/electronjs.org-new/pull/202