Erick Zhao comments

Results 246 comments of


                                            Erick Zhao

New name & logo

`birds-of-a-feather` tweet together? 🐦

New name & logo

I hadn't heard of it in the context of computing either, just the original proverb!

Codesign fail after universal

Should be closed in #72

How to package the .app returned by universal into pkg for distribution?

Would this not work? https://github.com/electron/osx-sign?tab=readme-ov-file#electron-osx-flat

Even when setting "tool":"notarytool" still get the legacy warning

I think this should be fixed as the legacy implementation was removed in #187

parallel download race condition errors out with: dest already exists

Thanks for the report @kneirinck! We've actually run into this somewhat frequently in CI on this very repo, which is annoying 😓 .

Ignoring `node_gyp_bins` directory is not working, causes signed & notarized apps not to pass gatekeeper

@samdesota Thank you for the clear issue report! In Forge, the Rebuild step happens in an `afterCopy` hook, so it turns out that filtering the file during the copy step...

Add Horizontal Card

Thanks for making this! One question: do you think it would be better for the default behavior of this card to revert to vertical for mobile displays (since Bulma emphasizes...

singleArchFiles minimatch doesn't work for files in .webpack folder

I think that'd be functionally identical to `{.*,*}/**/*.jsc` with `dot: false` as well. I personally would prefer to keep `dot: false` since it's the default for `minimatch`.

App entrypoint fails to load for ESM app if arm64 and x64 apps don't match

Hey @bendemboski, I was taking a look at this today and it seems like the repro case happens whenever the x64 and arm64 ASARs diverge. Converting the `asar.js` shim into...