Erick Zhao

Results 246 comments of Erick Zhao

I can't seem to reproduce on my end with the typescript webpack template. Errors are properly output when I `yarn package`: ``` ERROR in ./src/renderer.ts:33:13 TS2339: Property 'timeout' does not...

Oops yes I just forgot to write that part out. Happens sometimes when I'm writing longer docs, sorry! I'll make a follow-up PR today. :)

Hi @Bug-Reaper, thanks for the confirmation! I found an [Apple Developer Forum thread](https://forums.developer.apple.com/forums/thread/718887) that seems to point out that this might be a problem with the size of the app...

Also moved this issue into the correct upstream repo :)

superseded by https://github.com/electron/packager/commit/8d64aa1777af1c714f7c9cd67aae7b132635e7fe

Updated the PR with the requested changes (ESM and nvmrc). A few notes: * The APIs in this package still use callbacks instead of promises. Not sure if we want...

We're using the nullish coalescing operator which requires Node 14: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Nullish_coalescing What version of Node are you using?

Hi, if this issue is still valid, could you provide a minimal repro to help triage? Thanks!

@msimoni18 can you clarify if you're using a specific set of plugins/templates, or if this behaviour is reproducible with the base Forge config?

Might fold this into https://github.com/electron/forge/issues/3738