Eric Lau

Results 34 comments of Eric Lau

There is also some inconsistency between what is documented: library or interface or both. For example: - [ownable](https://docs.openzeppelin.com/contracts-cairo/0.3.1/access#ownable_library_api), [access control](https://docs.openzeppelin.com/contracts-cairo/0.3.1/access#accesscontrol_library_api), and [upgrades](https://docs.openzeppelin.com/contracts-cairo/0.3.1/proxies#upgrades_library_api) have their library API documented (with snake case)....

This is supported through the `custom` contract type in the API. Handling of custom storage variables is not included since storage variables are generic to the Cairo language, whereas Wizard...

Stacktrace contained the following: ``` 2021-06-18T18:36:40.519+0000 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] Caused by: org.gradle.tooling.GradleConnectionException: Could not install Gradle distribution from 'https://services.gradle.org/distributions/gradle-6.8.3-bin.zip'. 2021-06-18T18:36:40.519+0000 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] at org.gradle.tooling.internal.consumer.DistributionFactory$ZippedDistribution.getToolingImplementationClasspath(DistributionFactory.java:139) 2021-06-18T18:36:40.519+0000 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] at org.gradle.tooling.internal.consumer.loader.CachingToolingImplementationLoader.create(CachingToolingImplementationLoader.java:41) 2021-06-18T18:36:40.519+0000 [ERROR]...

@mezarin The issue should be fixed in the latest snapshot. Can you verify it with the buildscript section configured as follows in your build.gradle? ``` buildscript { repositories { mavenCentral()...

With the above PR, a different error now occurs as shown below. Even if we [pass in the gradle user home directory to the ProjectConnection as per the above PR](https://github.com/OpenLiberty/ci.gradle/pull/609/files),...

Just a note, `-Dgradle.user.home=` didn't work for me on Mac when the default `~/.gradle` has no write permissions. I get `Failed to load native library 'libnative-platform.dylib' for Mac OS X...

Reproduced this in the given stack (but without skipping tests), logs are below. Looks like a timing issue. The sequence of events in this case are: 1. Server started but...

To summarize, support has been added for tracking file content changes in bootstrap properties and JVM options files. Server.env file content changes are not yet tracked, since dev mode needs...

For tests, dev mode waits [0.5 seconds](https://github.com/OpenLiberty/ci.common/blob/2daebf400b1eac28c14a783523b2a9426f9e0142/src/main/java/io/openliberty/tools/common/plugins/util/DevUtil.java#L314) before starting tests to ensure they are not run multiple times if the OS saves a file multiple times. For compile, we should...

Hi @baumato , this is an issue with how dev mode compiles classes, so one workaround would be to force Maven to recompile the classes before you hit breakpoints. For...