Eric Lau

Results 146 comments of Eric Lau

Partially fixed by https://github.com/OpenZeppelin/openzeppelin-upgrades/pull/859 to allow using proxies with different admin addresses than what is in the network manifest. The remaining part is the ability to deploy different proxy admins,...

This should include: - Adding an option under Votes for ERC20 and ERC721 - Adding an option in Governor, so that GovernorSettings is initialized using timestamp-compatible values.

Cancelling this PR in favour of implementing this in the library first.

A relevant detail is that in 4.9.3, Ownable2StepUpgradeable's initializer does call OwnableUpgradeable's initializer: https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable/blob/v4.9.3/contracts/access/Ownable2StepUpgradeable.sol#L21 But in 5.0.0, it doesn't: https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable/blob/v5.0.0/contracts/access/Ownable2StepUpgradeable.sol#L37

Sorry for the late response. From the thread above, it looks like some settings are being passed through to the language server, but you have additional source files in certain...

I couldn't get the config working either. Will need to look into it further.

If you really need it for now, you could just edit the defaults in the [source code](https://github.com/ericglau/cairo-ls/blob/main/server/src/server.ts) and then build it by following https://github.com/ericglau/cairo-ls/blob/main/CONTRIBUTING.md -- only need the first 3...

If you need to call a function on your new implementation during the upgrade (such as to call a reinitializer), you can just call `upgradeProxy` as documented in the readme....

`prepareUpgrade` is similar to `address(new MyContractV2());` but it also validates the new implementation for upgrade safety as a prerequisite before deploying it. In order for the validations to work, in...

Right, this issue will need to be fixed in order for 4.x to be used with Upgrades.sol. To upgrade without `openzeppelin-foundry-upgrades`, it would be like: ``` address newImpl = address(new...