Eric Wieser

Results 440 comments of Eric Wieser

One failure remains: https://dev.azure.com/numpy/numpy/_build/results?buildId=6980&view=ms.vss-test-web.build-test-results-tab&runId=1082926&resultId=101493&paneView=debug Fix is to change this line: https://github.com/numpy/numpy/blob/01289c221ef45ed398f5c3822501692e849f1859/numpy/core/tests/test_machar.py#L19 Which probably can go in #15126 too

It's reassuring how few changes were required in #15126 and our test suite.

I remember large chunks of scipy that were sloppy about this, but I think a motivated user could fix them one by one. So I'd agree with leaving this open,...

The bug is in `_to_string_or_unicode_array`, which impacts all of: * `mod` * `decode` * `encode` * `expandtabs` * `join` * `partition` * `replace` * `rpartition` The fix is probably to...

@cosama: please open a new issue, that seems unrelated

Should we do the same for `np.object_` vs `np.object`?

What is the itemsize of `T{ix}` with this patch?

For anyone else reading this, some relevant python bug/discussions are here: https://bugs.python.org/issue26746 https://bugs.python.org/issue3132

Some possible solutions here for when no email can be found: * Search through all the commits until one is found with a matching `user.name`, and use the email from...