Eric Wieser

Results 440 comments of Eric Wieser

@chunweiyuan: Thanks for pointing out the merge conflict, I can go fix that. There was a lack of decision in the comments of #9213 whether `quantile` should be in the...

Looks like you did something screwy with a merge/rebase there. I've seen that behaviour before, but don't remember the cause.

Ok, looks like actually github was being screwy - changing the base twice has removed the commits from #9475 from this PR, which was what was weird in the first...

For the record: Fixes #6326

Irrespective of what happens to #10199, you should be able to revive this and add a `weights` argument to `percentile` (or more specifically, the `_quantile_unchecked` function within).

Rebasing will likely fix that.

In the past it's been due to having a pre-circleCI base commit on the PR branch, which merging or rebasing will resolve.

Would be good to prioritize #10199 over this one, because that will make this diff smaller

I'm unmilestoning this - @charris is aiming to get 1.15 out soon, and I think this PR warrants a long mailing list discussion about how exactly to define a weighted...

> To further drive my point, we can also look at this example from SAS: > https://blogs.sas.com/content/iml/2016/08/29/weighted-percentiles.html > The results therein are nothing more than the proposed method with a...