Eric Wieser

Results 440 comments of Eric Wieser

> * you are 100% sure that after merging the branch it won't break at all With the caveat, _if you haven't pushed anything else to the target branch_.

> Right -- it seems this approach is invalidated immediately once something has been pushed to the master branch after the build has happened. Invalidated seems like a strong word....

> To use a sportsball analogy: > > * `/merge` — a randomly moving goalpost, shrouded in fog > * `/pull` — periodically blowing the fog away and taking a...

A variant of this request; I have a LuaLaTeX file that loads in a ttf font, which I want to generate an SVG from. My website will already be serving...

> GitHub also uses linguist to highlight code blocks in Markdown, per my understanding. What is the mapping between ```` ```foo ```` and the language chosen by linguist?

Is there an alternative format to textmate-based grammars that uses the new system that we could contribute?

CI seems unhappy with this test: https://github.com/leanprover-community/lean/blob/cb0da9f301ab2b85d8d96847c41b92d973a7b151/tests/lean/interactive/info.lean#L15-L16 which no longer produces https://github.com/leanprover-community/lean/blob/cb0da9f301ab2b85d8d96847c41b92d973a7b151/tests/lean/interactive/info.lean.expected.out#L8

These lines will likely need to change too: https://github.com/numpy/numpy/blob/dcc1fc2f055253703d3883ad186c26bcf6b9b276/numpy/core/_methods.py#L83-L96

I think it might be worth renaming the python class members to be something like: ```python @_display_as_base class _UFuncCastingError(UFuncTypeError): def __init__(self, ufunc, casting, call_dtypes, loop_dtypes): super().__init__(ufunc) self.casting = casting self.call_dtypes...

> Any other opinions out there? If it were my choice I would want to have `np` on all parts Numpy is not the only module capable of defining ufuncs,...