Eric Milles

Results 170 comments of Eric Milles

I still come back to some network security thing. Can you try Eclipse 4.27 just to see if we can learn anything different?

When I got to the same link, it does start a download. I think artifactory does some redirect(s).

Can you take this to jfrog? Seems like their redirect mechanism is not working for some reason with your network settings.

One of the related problems from Grails (see GormEntityTransformation) is this: ```groovy if (classNode instanceof InnerClassNode || classNode.isEnum()) ``` The second occurrence of `classNode` gets cast to `InnerClassNode` due to...

I'm reluctant to merge myself because GROOVY-11769 is about bytecode optimization, not failing functionality. And GROOVY-11375 was not strong enough on its own to make this change earlier.

"always enabled" should probably read "enabled by default" -- it is still possible to disable until all the call site code is removed (see #1934)

You can still set system property "groovy.target.indy" to false or you can set optimization option "indy" to false. This will enable the old call site code generation. These default to...

I think the ASM version is the main compat vehicle. Isn't Groovy 4 and 5 already tested against 25? Gradle 9 is not a high priority item for older branches,...

You can probably remove the null check on lines 55-57. Is there any hope for a test case?

If the `DefaultFastStringService` comes from the `groovy-json` module, is it supposed to be available via service loading? Sorry, I'm a bit behind in the discussion.