Eric Milles

Results 139 comments of Eric Milles

`AbstractTypeNameAstVisitor` or `visitClassEx` should be tagged `@CompileStatic` if the intent is to use it across major Groovy versions. The changes to super method indexing in `MetaClassImpl` can cause problems for...

Would it be possible to summarize the different scenarios surrounding variadic method calling and show where dynamic, STC and SC are giving expected or unexpected results? There is so much...

The change is definitely more palatable in size. For expression type determination during classgen, I think the `TypeChooser` should always be used. The sequence of checking expression class types and...

-1 for me I will look over your tests and see about adding them to the build at least to demonstrate GROOVY-10099. `InvocationWriter#loadArguments` already has significant checking/handling for variadic situations....

Are there any test cases that use `and`, `or`, `xor` and now `not` as extension methods? I'd be interested to see if the style you seek is indeed supported. Is...

For STC, there are a couple methods that check the compatibility of arguments and parameters or source and target types. I would expect a change in one of these to...

Does this change accommodate checking `instanceof` under a ternary expression or as part of a larger boolean expression? ```groovy int m(o) { (o instanceof List || o instanceof Map ?...

Isn't the JDK providing [HttpClient](https://docs.oracle.com/en/java/javase/11/docs/api/java.net.http/java/net/http/HttpClient.html), HttpRequest and HttpResponse as part of Java 11?

Yes, to add support for the switchover, you can add an extension like this: https://github.com/groovy/groovy-eclipse/blob/master/ide/org.codehaus.groovy.eclipse.ui/plugin.xml#L1211 The idea is to add pseudo-selectors in the CSS that match your preference names. [https://avatars3.githubusercontent.com/u/64846?s=400&v=4]...

This is the Guava bundle that Eclipse Oxygen 4.7.2 + Eclipse-Checkstyle 8.5.1 has: com.google.guava_21.0.0.v20170206-1425.jar The manifest for the net.sf.eclipsecs.checkstyle bundle does not specify a version of the exported package com.google.common.collect....