Benoit Daloze

Results 1300 comments of Benoit Daloze

Let's find the embedding requirements based on https://github.com/ruby/prism/discussions/2217 It seems so far we can do with just macros and don't need configure-like detection. > how would you detect a processor...

I think the best solution here is to only use arena allocations. And to allocate the arena itself then `malloc`/`xmalloc` can be used. That would provide the best performance and...

Is there maybe another way these 2 usages could do what they do once they migrate to Prism? (they will need to change anyway since they use the experimental unstable...

What is the advantage of doing so? The disadvantage is it likely causes extra resource consumption (CPU & memory).

I see. Could you share a repro for that? I'd like to try it locally.

Could you start a PR to fix and add specs for this? It's probably just using `*args` somewhere without `ruby2_keywords`.

Thank you for the issue report. I generally agree we should fix this if we can. The question is how. (1) We could (try to) use a lock around the...

I've filed an issue on the CRuby tracker to see what they think about the same problem for core `Hash`: https://bugs.ruby-lang.org/issues/19237

FWIW CRuby closed that ticket and added documentation that Hash is not thread-safe for that case: https://bugs.ruby-lang.org/issues/19237#note-2 and https://github.com/ruby/ruby/commit/ffd52412ab813854d134dbbc2b60f698fe536487. I think it makes sense to solve this for Concurrent::Hash and...

Thanks for the report. Yes, that makes sense, a PR would be helpful.