Benoit Daloze

Results 1300 comments of Benoit Daloze

If you use `resolv-replace` (the only way to interrupt DNS lookup currently AFAIK) Timeout.timeout will work. So that's a clear advantage. Also see https://bugs.ruby-lang.org/issues/19430, that would solve it but it's...

@kddnewton Any thoughts regarding that last sentence? IIRC IRB also wanted this predicate for syntax errors.

I'm not sure, maybe @nurse would know since he authored that change? I think we should first check if it changes anything performance-wise, maybe those builtins are not used or...

> Note that as far as I understand `-std=c99` doesn't provide you more portability. Do you mean better to not specify any `-std=`, do you mean `-std=gnu99` is as portable...

Sort of related: https://bugs.ruby-lang.org/issues/20406 We're trying to figure the actual rules for a Regexp literal's `Regexp#encoding`. There is actually some docs on it in `ri Regexp` from Ruby 3.3.

Yeah agreed let's keep that workaround for existing releases and link to the relevant issues to make it easy to figure out from the code why that is needed

There are two gains: 1. It would make loading from the serialized AST on disk quite a bit faster, by not needing to read the source (and only check its...

> We would also need the DATA constant to be stored in the file as well True, although this would only be for the main file/script. I think Prism doesn't...

Yes, when serialized it's already 32-bit ints and actually in Java it's a 32-bit signed integer, so only 31 bits. Related: https://github.com/ruby/yarp/issues/872#issuecomment-1572518200 and https://github.com/ruby/yarp/issues/1407#issuecomment-1708042576 Also https://github.com/ruby/yarp/pull/1532 for stats on the...

I think first we should clarify what exactly we need to check, and check that it cannot be done via the preprocessor or directly in the source code with some...