Benoit Daloze
Benoit Daloze
`send` is quite a big overhead, so that should be addressed (e.g. via eval) if such a convenience method is added.
@sferik (or anyone else who can merge a PR here) I rebased this and fixed the conflicts, could you merge it?
FYI I'm planning to try adding TruffleRuby in CI to catch such issues faster, but that needs more work so I would suggest merging this first.
Confirmed this PR reduces `bundle exec rake spec` from 9 to just 1 failure on truffleruby-dev.
@PragTob @colszowka Hello, it would be great if this can be merged and released when you have some open-source time, because the latest release breaks a bunch of CIs testing...
Ping, please merge and release this. It's been one month and a half and it still breaks the CI of e.g. https://github.com/ronin-rb/ronin/actions/runs/4089986844/jobs/7053088486 Can I do anything to help with this?
@notEthan If the issue is SimpleCov 0.21.2 + TruffleRuby, that's solved in recent TruffleRuby releases and since https://github.com/simplecov-ruby/simplecov/issues/1044#issuecomment-1529783628, because TruffleRuby has `Coverage.running?` since then.
I can make a PR for it after https://github.com/simplecov-ruby/simplecov/pull/1043 is merged.
Yes TruffleRuby supports Line coverage since many years and it passes the specs except for 1 failure: https://github.com/simplecov-ruby/simplecov/pull/1043#issuecomment-1365158528
> In that case, not running coverage on TruffleRuby on some side might be preferable. That's an interesting question. For most gems I would expect it's enough to run coverage...