Benoit Daloze
Benoit Daloze
Duplicate of https://github.com/ruby/setup-ruby/issues/191, follow updates there.
Update: CI is green on Linux and macOS. https://github.com/eregon/childprocess/actions/runs/4235205251/jobs/7358538501 On Windows there is a single failure: ``` 1) ChildProcess kills the full process tree Failure/Error: raise msg RuntimeError: timed out...
Given the latest release is 4.1.0, I think this change would deserve its own major version, i.e. 5.0.0.
I'll try to rebase this soon. That missing coercion can easily be solved, although it would be nice to have a test for it.
Rebased, and I added a test for Symbol keys and values in process.environment (+ fixed it using the same logic as before).
I'm tweaking a bit the CI and self-reviewing, I'll write here when it's ready for review (and also request via GitHub).
This is ready now, the CI tests every Ruby from 2.4 (the required_ruby_version) to 3.3 as well as jruby and truffleruby. JRuby on Windows fails to load rspec, which is...
@dentarg > Not a concern for this PR, as it removes all usage of ffi (🤩) but maybe something you want to look into for TruffleRuby in general @eregon? Or...
> Would it be possible to incrementally replace the internal implementation? Swap the OSX and Linux parts because core Ruby works fine but keep the Windows specific functionality in place...
The bug was only in the representation (#to_s), so the internal expression is correct, although not totally optimized. You can try the latest symbolic with Bundler, fetching directly from the...