simplecov
simplecov copied to clipboard
allow Coverage to start when Coverage.running? is not implemented
Amends https://github.com/simplecov-ruby/simplecov/pull/1035/commits/1cc7650454fc7c53e7a724941662c3e9d3329ccc from #1035
Another option would be to just call Coverage.start unconditionally and rescue the RuntimeError it now raises when already started.
FYI I'm planning to try adding TruffleRuby in CI to catch such issues faster, but that needs more work so I would suggest merging this first.
Confirmed this PR reduces bundle exec rake spec from 9 to just 1 failure on truffleruby-dev.
I also started looking yesterday at adding truffle to the CI here, but got hung up on aruba/childprocess, then saw that you were ahead of me and had opened an issue about the same already.
@PragTob @colszowka Hello, it would be great if this can be merged and released when you have some open-source time, because the latest release breaks a bunch of CIs testing TruffleRuby (e.g. see backlinks to this PR and #1044)
Yes, it would be quite helpful if this fix could make it into a release.
Ping, please merge and release this. It's been one month and a half and it still breaks the CI of e.g. https://github.com/ronin-rb/ronin/actions/runs/4089986844/jobs/7053088486 Can I do anything to help with this?
I've been stuck with this:
- https://github.com/filewatcher/filewatcher-matrix/pull/47
- https://github.com/filewatcher/filewatcher-cli/pull/93
Thanks for this, sorry for all the silence. Life and more happend, been a tough year+. I'll merge, it should be fine famous simplecov maintainer last words
Thanks y'all for your work :green_heart:
@notEthan : Very cute bunny avatar!
Thanks for merging. A release with this would make it usable.
@notEthan If the issue is SimpleCov 0.21.2 + TruffleRuby, that's solved in recent TruffleRuby releases and since https://github.com/simplecov-ruby/simplecov/issues/1044#issuecomment-1529783628, because TruffleRuby has Coverage.running? since then.