Benoit Daloze
Benoit Daloze
OK, I'll add myself a reminder in March to find some time to discuss this.
I had a call with @k0kubun, here is my summary of the call: * I'd like to simplify to 2 modes: * Existing `benchmark-driver bench.yml` * `benchmark-driver bench.rb` where `bench.rb`...
Regarding the issue of syntax highlighting for .yml files, one workaround could be to have some option for `benchmark-driver` to generate a Ruby file from the .yml file. That could...
@ko1 Specifically I'm proposing to remove the 3rd mode which is `benchmark-driver bench.rb` where `bench.rb` *does not* use the DSL, because I find that confusing and inconsistent with other modes...
FWIW, I recently noticed the sprtintf-related specs didn't work as intended (ending up using the same block saved in `@method` for all usages for the nested case). Essentially, nested `it_behaves_like`...
I think we should start a PR on ruby/spec to fix the warnings, because if we merge and there are hundreds of warnings it will be very annoying for all...
Hello, It sounds good, please make a PR removing the extra guards. Yes, you can use: ```ruby guard -> { platform_is :mingw and ruby_version_is ""..."2.4" } do # specs end...
Could you file the bug with `--random` as a separate issue actually?
@MSP-Greg I didn't realize `mathn` was removed in 2.5, interesting. Right, using `Prime` to know if `mathn` is loaded is indeed not a good guard. Thanks for the idea, I'll...
@MSP-Greg Done in https://github.com/ruby/spec/commit/c0cb934213b7dc727fb618cf092d497f37af7667. It looks like some specs in core do not pass with `mspec -rmathn core`, but I'm not sure it's worth fixing (maybe we should just drop...