Benoit Daloze

Results 1300 comments of Benoit Daloze

I've got 7min23s on https://github.com/eregon/redis-rb/runs/7887133053?check_suite_focus=true with `TRUFFLERUBYOPT=--engine.Mode=latency`. (I also did a 2nd run with your commit, https://github.com/eregon/redis-rb/runs/7887116546?check_suite_focus=true, 8m56s) IMHO that's already pretty fast for CI, so I think it'd make...

Hello, I assume you use a normal mx suite import in suite.py with a revision like https://github.com/oracle/truffleruby/blob/533f430d8a2eed49390442ab303996894e4e24a7/mx.truffleruby/suite.py#L7-L15 In that case, I think it's not easy to know which git `--depth`...

That doesn't seem to work for me (trying commit 56081af2d974b1650181f3d8496e1dd90a6a583b of mx): ```bash $ mkdir mx $ cd mx $ git init Initialized empty Git repository in /home/eregon/mx/.git/ $ git...

I noticed as well that cloning `graal` in TravisCI takes a very long time (250s = 4min10s): https://travis-ci.org/oracle/truffleruby/builds/618237461 I think it would be useful to integrate @fniephaus's workaround in mx,...

Unfortunately, the `git fetch origin --depth 1 "${TRUFFLE_COMMIT}"` approach only works if the commit in question corresponds to a tag or a branch, at least for GitHub: ``` $ git...

> Alternatively, it'd also be possible to download a zip from GitHub, for example https://github.com/oracle/graal/archive/cdcc1dbd9d5370b86b9fcf66401110d1b69d783e.zip. Interesting, there are also `.tar.gz` and they're only ~12MB in size (the `.zip` around 25MB)....

Here is another idea, based on https://stackoverflow.com/a/43926596/388803 and `git fetch --shallow-since=DATE`. For the date, we could use the last time the graal import was modified in `suite.py`, if always updating...

FWIW, I tried a `git gc --aggressive` in the graal repository: ``` $ du -hs .git 1.1G .git $ git gc --aggressive ... 22:04.69 total $ du -hs .git 446M...

In GitHub Actions `ubuntu-latest`: `git clone https://github.com/oracle/graal.git` (or `mx sforceimports`) takes 2min 36s. `actions/checkout` is a huge help there: ```yaml - name: Clone Graal uses: actions/checkout@v2 with: repository: oracle/graal path:...