Sebastian "Sebbie" Silbermann

Results 555 comments of Sebastian "Sebbie" Silbermann

It's definitely something to explore long term but not trivial to do. Does Deno not support any JS library that ships types in `@types/*`?

> isn't it just a copy paste from the https://github.com/DefinitelyTyped codebase into the facebook/react codebase ? It needs release coordination which isn't trivial considering the amount of users we have....

I maintain the React types and I'm on the React team. The TS types just weren't part of React historically so there's a lot of catching up to do.

This no longer reproduces on the latest Canary: https://codesandbox.io/p/sandbox/goofy-pasteur-268ly3 @dev2xl @Veath Could you confirm that you're also not seeing this issue in your apps anymore?

@sebmarkbage confirmed recently that this is intended: > `Document` also doesn't really work on `createRoot`. Only `hydrateRoot` should have `Document` as an option. > > You can however pass `document.documentElement`...

This will be supported in React 19. The original sandbox "just works" in the latest Canary release: https://codesandbox.io/p/sandbox/stupefied-cloud-wmcj43?file=%2Fpackage.json%3A9%2C51

I think there's a case for not resetting state. An error boundary that just renders children anyway is like rethrowing an error. But there's also a case for resetting state:...

This is intended behavior. We're resetting state to attempt to recover from the error. The idea being that the error might be based on the state being invalid/corrupted. Otherwise we'd...

When React is doing a concurrent render and something throws, it will re-render one more time synchronously in case the error was caused by inconsistent data stores. There is currently...

> Thanks for this. I didn't know that. That particular line may not have existed in the docs back when I read it. Also this is the only case I...