Sebastian "Sebbie" Silbermann
Sebastian "Sebbie" Silbermann
Maybe also discuss what matchers we could remove? `toHaveTextContent` ~is~ should just be `toHaveProperty('textContent', 'foo')` > I'm not sure which one to keep, but I find it too verbose in...
WRT to `isAccessible`: We now automatically exclude inaccessible elements in `@testing-library/dom#getByRole` with https://github.com/testing-library/dom-testing-library/blob/dbbea6ee514399d0b37690ce5c56bb21f5ae2cb3/src/role-helpers.js#L17 I think it's not public yet though. I'll start working on a chai matcher and report back...
@ghostd Thanks for offering help. Eventually [`dom-accessibility-api`](https://github.com/eps1lon/dom-accessibility-api#readme) should get a `computeAccessibleDescription` following the [`accname`](https://www.w3.org/TR/accname-1.1/) spec. So any effort should go into that package which has proper infra to test that...
It's very likely that this is an issue with JSDOM which doesn't implement the Cascade in CSS. Could you run the same test in an actual browser and share the...
> Anyway I'm bit confused. From Readme, if its parent element is also visible (and so on up to the top of the DOM tree) then the element is visible....
Hi, thanks for opening this issue and providing so much detail :+1: I follow the general gist of it but have some concern regarding the name. The name implies that...
> With the former you only need the option I generally want to optimize for readability. It's the thing we do more often than writing.
> What is it less readable about the proposed api? So readable was probably the wrong word. "reasonable" or "being a test that I can follow" may be more appropriate....
> An audacious alternative is to enhance toHaveFocus() so it returns true for elements that have this virtual focus too These match different CSS pseudo-classes so I wouldn't merge these....
The codesandbox does not use any of the code you described. Don't forget to save and freeze the codesandbox after submission. I suspect this is an issue with `jsdom` not...