Sebastian "Sebbie" Silbermann
Sebastian "Sebbie" Silbermann
Hm isn't this just a documentation issue? Auto-cleanup should be disabled in browsers anyway since `process` isn't defined there.
Yeah let's move this to documentation that you should use a bundler. That solves most use cases and once we think the ecosystem is ready for `exports` we can create...
> the DOM nodes aren't always removed, rather they're updated. Do you have an example for that?
Hmm I guess the problem is that removal is actual an implementation detail? What we're actually asking is: "Wait until this selector no longer matches an element". In which case...
This looks simpler anyway and [`MemoryRouter` is the recommended approach for testing](https://reactrouter.com/web/api/MemoryRouter) anyway. Want to send a PR that documents `MemoryRouter` instead?
> because you can't interop with window.location and other APIs that real apps use in conjunction with RR when using MemoryRouter. Shouldn't you use `useLocation` anyway? Especially because accessing `window.location`...
@poteto that should've been fixed in https://github.com/facebook/react/pull/26206#issuecomment-1437486474
I believe the appDir already works as many in here want it to be: `process.env.*` is not statically baked into the final bundle at build time but read at runtime:...
@manovotny `getStaticProps` seems to imply secrets are read at build time without making any mention of runtime which we're asking for here. This issue is not resolved for me by...
> @eps1lon Is my example in https://github.com/testing-library/react-testing-library/issues/1051#issuecomment-1103104238 comment not sufficient to demonstrate the issue? @intercaetera It's not runnable. Even after fixing the lockfile (`npm ci` failed), `npm test` I got...