Sebastian "Sebbie" Silbermann

Results 570 comments of Sebastian "Sebbie" Silbermann

A test that mimics how you would use, would help. Looks like none of the existing tests really showcase a need for this feature since it's just used on the...

> I think if an object is created from a literal in one place it should always have the same hidden class, but I'm curious if I'm missing something here...

> Do you have any pointers on existing features in React that might follow this pattern of "save data from some native event and use it to polyfill a field...

> possibly! Could you point me at anywhere in particular? I am motivated to help with this but 100% noob on the React codebase. I'm not familiar with most of...

> Why is it necessary? Isn't it purely an artificial limitation? It's necessary to have some way to distinguish what is a hook and what isn't. Pascal case was already...

It doesn't look like this bug report has enough info for one of us to reproduce it. Please provide a CodeSandbox (https://react.new), or a link to a repository on GitHub....

> I have seen that many large libraries use portals with document.body, so far it has not given me any problems. It's a perf issue as far as I know:...

Interestingly, trimming was intentionally added and considered "correct" (see commit message): https://github.com/facebook/react/commit/2bff5c5c7e776a183ed9b429f2cb46cc044d9bc1. Considering that whitespace is a valid token for custom properties ([2. Defining Custom Properties: the --* family of...

> I can't replicate the suffix being added (both v16 + v17 behave the same - see: [codesandbox.io/s/solitary-pond-v0i69?file=/src/App.js](https://codesandbox.io/s/solitary-pond-v0i69?file=/src/App.js)) - I wonder what use case it's wanting to handle? Maybe this...