Egor Potemkin

Results 7 comments of Egor Potemkin

Thank you fore reviewing @mikemccand ! Resolved your comments in 2nd commit.

@mikemccand oh I've just realised that replying to code line comment doesn't send a notification! Thank you for reviewing, I listed some alternatives above, but I still think that current...

> [gsmiller](/gsmiller) > @epotyom I'd be happy to do a pass on this and help get it merged if you like. Would you mind resolving the current merge conflicts then...

Thank you for reviewing @gsmiller ! I've addressed your comments and updated the branch.

In my opinion, the new approach can eventually do everything the current approach does, but there are quite a few gaps to cover, see Milestone 2 in [the plan document](https://docs.google.com/document/d/1PF9KWYboy6terrPp8Frizlkp1ee09RX-DsuZrBux-Oo/edit?usp=sharing)....

Thanks @jpountz for [bringing this up as a feature for Lucene 10](https://lists.apache.org/[email protected]). It would be great to have if we can build it! A few of us in Amazon Product...

@benwtrent this change gives us significant enough performance boost, I think it is because BooleanWeight has optimizations for clauses which return `null` scorerSupplier https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/search/BooleanWeight.java#L293 But looks like it is bad...