lucene
lucene copied to clipboard
apache
Add Facets#getBulkSpecificValues method
Add Facets#getBulkSpecificValues method and implemented it in every class that implements getSpecificValue.
Also moved FacetLabel class one level up from org.apache.lucene.facet.taxonomy to org.apache.lucene.facet to be able to use it as argument for getBulkSpecificValues.
Issue #12919
Thank you fore reviewing @mikemccand ! Resolved your comments in 2nd commit.
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution!
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@mikemccand oh I've just realised that replying to code line comment doesn't send a notification!
Thank you for reviewing, I listed some alternatives above, but I still think that current approach is better and I think it's ok to only merge to 10.0, but please let me know if you think otherwise.
I've rebased the branch to resolve conflicts.
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution!
@epotyom I'd be happy to do a pass on this and help get it merged if you like. Would you mind resolving the current merge conflicts then I'll have a look?
gsmiller
@epotyom I'd be happy to do a pass on this and help get it merged if you like. Would you mind resolving the current merge conflicts then I'll have a look?
Thanks @gsmiller , I've rebased the branch.
@epotyom I saw Mike already approved. I did my own pass anyway so I understand the changes. They look good. Thanks! I left one small question for you about a default implementation. Let's resolve that open question then I'll merge.
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution!
Thank you for reviewing @gsmiller ! I've addressed your comments and updated the branch.
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution!
Hmm it looks like this change was nearly ready to be merged? But code has since drifted and the PR now has some rust (conflicts)?
